Enable range sampling for 128-bit integers #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhardy
added a commit
to dhardy/rand
that referenced
this pull request
Aug 17, 2017
|
In some sense this PR is already merged, right? |
|
In my branch, yes, but there's not really any reason we can't merge this first. At least this PR gets it right unlike the other one :) |
pitdicker
pushed a commit
to pitdicker/rand
that referenced
this pull request
Apr 4, 2018
Enable range sampling for 128-bit integers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As an enhancement for #140, this patch adds support for range sampling.
I'm kinda new to Rust so this change may look naïve or even problematic. I'll try to improve it if needed.